Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category titles persist after closing bag window #354

Closed
joao44289 opened this issue May 2, 2024 · 14 comments
Closed

Category titles persist after closing bag window #354

joao44289 opened this issue May 2, 2024 · 14 comments
Assignees
Labels
bug Something isn't working triage

Comments

@joao44289
Copy link

Addon Version

v0.1.33

World of Warcraft Version

Retail

Describe the bug

Sometimes after closing the bag window some category titles persist and only go away after a /reload.
bug

Steps to reproduce

  1. It seems to happen at random times so not sure what are the steps to reproduce it.
@Cidan
Copy link
Owner

Cidan commented May 2, 2024

That's odd! I'll hunt this down and fix it asap.

@flo187dev
Copy link

this happens to me as well with all category titles of bank bags. they stay after closing the bank and only a /reload will fix it. surprisingly the bug occurs even after disabling all other addons.

thanks for looking into this!

image

@Cidan
Copy link
Owner

Cidan commented May 2, 2024

I'm having a hard time reproducing this, but this part of the code was slated for a rewrite anyway.

If possible, can you detail the exact order in which you caused this to happen?

@flo187dev
Copy link

flo187dev commented May 2, 2024

my screenshot above only involves 2 steps:

  1. Talk to Banker
  2. Close Bank window

some other things I noticed:

  • I've now deleted BetterBags.lua in SavedVariables but that didn't change anything.
  • I don't use custom categories
  • it never happens to the regular bags
  • I've always had the issue at the bank since I started using BetterBags a couple of months ago.
  • It also doesn't matter if I try it after logging in or after hours of playing
    edited to add:
  • It is not character specific

@Cidan
Copy link
Owner

Cidan commented May 2, 2024

I've always had the issue at the bank since I started using BetterBags a couple of months ago.

This is a huge red flag for me, wow, I had no idea! I wish I could have helped with this sooner.

When you close the bank, do you hit the X button, or do you walk away? What exactly do you do to close the bank?

@flo187dev
Copy link

This is a huge red flag for me, wow, I had no idea! I wish I could have helped with this sooner.

I only mentioned it to narrow down the issue. :) as it is only when using the bank it didn't affect me too much and I figured it was because of early development.

I've now tried the X button, Escape key and walking way. Same results for all three.

@flo187dev
Copy link

not sure if this info helps but the titles retain some (buggy) responsiveness like being clickable and showing a tooltip on hover:

image

@flo187dev
Copy link

oh i found something! it seems to only happen when "Use UI Scale" is checked in System > Graphics.

image

@flo187dev
Copy link

flo187dev commented May 2, 2024

some additional info:

so it only happens when enabling the checkbox AND using 100% scaling. The category headers behave normally with the checkbox disabled or on any other scaling factor, even 99% or 101%.

why do I check the box but keep the setting at 100%? well it does change the UI size compared to not checking it... I'm using a 3440x1440 high(-ish) DPI monitor so text & ui are a bit small when NOT checking the box.

so as a workaround, using 99% or 101% works for me :) hope it helps @joao44289 as well

@Cidan
Copy link
Owner

Cidan commented May 3, 2024

wow! that's crazy -- i'll see if i can hunt this down later tonight

@Cidan
Copy link
Owner

Cidan commented May 3, 2024

Alright, thanks to @zeptognome for the help, we fixed the bug. Putting out a release soon for this.

@Cidan
Copy link
Owner

Cidan commented May 3, 2024

Some more info, we definitely think this is a bug in Blizzard's code, as I don't think this should have been happening as-is. We implemented a fix (thought admittedly, it's something we should have done all along) and is out in the latest alpha build.

@flo187dev
Copy link

this fixed it for me regardless of scaling on/off or slider setting. thanks! :D

@Cidan
Copy link
Owner

Cidan commented May 4, 2024

This has been fixed and deployed.

@Cidan Cidan closed this as completed May 4, 2024
@github-project-automation github-project-automation bot moved this from To Triage to Released in BetterBags Issue Tracker May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
Archived in project
Development

No branches or pull requests

3 participants