Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add an icon for Blizzard's bag cleanup tool #312

Closed
Myrroddin opened this issue Mar 23, 2024 · 10 comments
Closed

[Feature]: Add an icon for Blizzard's bag cleanup tool #312

Myrroddin opened this issue Mar 23, 2024 · 10 comments
Assignees

Comments

@Myrroddin
Copy link

Describe the feature

There is a great spot right next to BetterBags' icon to place Blizzard's bag cleanup tool. This should exist on the bags, bank, and reagent bank. Either place the tool next to BetterBags' icon or place the tool on the far right to prevent misclicks.

Describe the implementation

Classic and Wrath do not have Blizzard's bag cleanup tool. However, there is the addon SortBags which provides the same feature. You could even adapt AdiBags - Cleanup which uses SortBags to mimic retail WoW.

@Cidan
Copy link
Owner

Cidan commented Mar 23, 2024

Right click the bag icon to sort -- this has been in for quite some time. However, I like the idea of integrating with SortBags -- I'll do this.

@Cidan
Copy link
Owner

Cidan commented Mar 24, 2024

Latest alpha implements this feature in Classic. Bank isn't implemented yet across any SKU and will come soon.

@Cidan Cidan closed this as completed Mar 24, 2024
@github-project-automation github-project-automation bot moved this from To Triage to Released in BetterBags Issue Tracker Mar 24, 2024
@Myrroddin
Copy link
Author

Oh, I thought the right-click was merely a visual thing that only affected the display in BetterBags. I didn't know that was actually sorting the bags, mostly because I couldn't find a way to disable the BetterBags skin without disabling the entire addon.

@Myrroddin
Copy link
Author

I'm not sure if you covered this when you added SortBags support. I glanced at your commit and might have missed it. SortBags has two commands.

  • SortBags() which is for the character's bags
  • SortBankBags() which is for the character's bank bags

I saw SortBags() but if you added SortBankBags() I missed the feature.

@Cidan
Copy link
Owner

Cidan commented Mar 25, 2024

Latest alpha implements this feature in Classic. Bank isn't implemented yet across any SKU and will come soon.

In my original message to you. :)

@Cidan
Copy link
Owner

Cidan commented Mar 25, 2024

I didn't know that was actually sorting the bags, mostly because I couldn't find a way to disable the BetterBags skin without disabling the entire addon.

Click the menu -> Show Bags. This will show you bags as they are in Blizzard's layout.

@SpareSimian
Copy link

I'm reminded today when looking at my Altoholics panel that sorting the raw bags would be useful so I can find things in alts' bags when looking in the Altoholics panel. (Altoholics has a search feature but sometimes it fails to find something I know I have. Or I can't remember the name of something I know I have and don't want to switch toons to look it up.)

@Myrroddin
Copy link
Author

I didn't know that was actually sorting the bags, mostly because I couldn't find a way to disable the BetterBags skin without disabling the entire addon.

Click the menu -> Show Bags. This will show you bags as they are in Blizzard's layout.

This works, but only for the character's bags. When showing the Blizzard bags at the bank or reagent bank, there is no sorting mechanism, whether through BetterBags or access to the Blizzard sorting tool.

Showing the Blizzard layout is one thing, not having Blizzard's sorting tool is another.

@Cidan
Copy link
Owner

Cidan commented Apr 29, 2024

Yes, bank sorting is on my todo list -- it's going to come with the planned bank overhaul for TWW.

@Myrroddin
Copy link
Author

Yes, bank sorting is on my todo list -- it's going to come with the planned bank overhaul for TWW.

Nice! Hopefully, you can get the bank sorting feature for BagSort working in Classic too. Big things are coming, with BetterBags improving all the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants