Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdiBags compatibility: Custom Filter widget broken #237

Closed
bloerwald opened this issue Feb 25, 2024 · 2 comments
Closed

AdiBags compatibility: Custom Filter widget broken #237

bloerwald opened this issue Feb 25, 2024 · 2 comments
Assignees
Labels
bug Something isn't working triage

Comments

@bloerwald
Copy link

Addon Version

v0.1.8

World of Warcraft Version

Retail

Describe the bug

With AdiBags v1.10.24 and BetterBags v0.1.8 both installed, modifying AdiBags categories is no longer possible, probably due to reusing the AceConfig widget partially. In AdiBags, the widget always claims to be completely empty:

image

Steps to reproduce

Install both addons, open AdiBags options > Filters > custom.

@SpareSimian
Copy link

Good guess. Based on your hint, I changed the name of the custom ItemList control to BBItemList and AdiBags started displaying item lists against. Here's a patch:

diff --git a/BetterBags/config/config.lua b/BetterBags/config/config.lua
index 297ff4c..1da3e01 100644
--- a/BetterBags/config/config.lua
+++ b/BetterBags/config/config.lua
@@ -140,7 +140,7 @@ end
 function config:OnEnable()
   self.helpText = {}
   self:CreateAllHelp()
-  GUI:RegisterWidgetType("ItemList", config.CreateItemListWidget, 1)
+  GUI:RegisterWidgetType("BBItemList", config.CreateItemListWidget, 1)
   LibStub('AceConfig-3.0'):RegisterOptionsTable(addonName, function() return self:GetOptions() end)
   self.frame, self.category = LibStub("AceConfigDialog-3.0"):AddToBlizOptions(addonName, "BetterBags")
   LibStub("AceConfigDialog-3.0"):SetDefaultSize(addonName, 700, 800)
diff --git a/BetterBags/config/customcat.lua b/BetterBags/config/customcat.lua
index 0cade21..0742f68 100644
--- a/BetterBags/config/customcat.lua
+++ b/BetterBags/config/customcat.lua
@@ -26,7 +26,7 @@ function config:CreateCustomCategoryConfig(category)
       items = {
         type = "multiselect",
         name = L:G("Items"),
-        dialogControl = "ItemList",
+        dialogControl = "BBItemList",
         order = 1,
         values = DB:GetItemCategory(category)
       },

@zeptognome
Copy link
Collaborator

Closing this as Adibags support has been discontinued, and additionally, BetterBags is moving away from using the AceConfig for custom category item lists

@zeptognome zeptognome closed this as not planned Won't fix, can't repro, duplicate, stale Aug 1, 2024
@github-project-automation github-project-automation bot moved this from To Triage to Released in BetterBags Issue Tracker Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
Archived in project
Development

No branches or pull requests

4 participants