Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for "follower" or "champion" ignores items with "follower" or "champion" in the item "use:" text #180

Open
radhaz opened this issue Feb 20, 2024 · 3 comments
Assignees
Labels
bug Something isn't working triage

Comments

@radhaz
Copy link

radhaz commented Feb 20, 2024

Addon Version

v0.1.6

World of Warcraft Version

Retail

Describe the bug

When searching for items using the word "champion" or "follower" in the "use:" text such as Curio of Abundant Happiness or Fortified Armor Enhancement search does not return results.

Steps to reproduce

  1. With item(s) in bag/bank shift left click to bring up search
  2. Type "follower" (or "champion" depending on item)
  3. Observe all items in inventory grey out, including the ones containing text for Follower or Champion

Note

This can be reproduced regardless of upper or lowercase

@AMaribo
Copy link
Collaborator

AMaribo commented Feb 20, 2024

From some limited testing, the search function only seems to be searching through the item name and not any other properties of the items.

@radhaz
Copy link
Author

radhaz commented Feb 20, 2024

From some limited testing, the search function only seems to be searching through the item name and not any other properties of the items.

It does seem that way and it's why I made a feature request for a "deeper search"; however, the dev suggested this was a bug and directed me to open a bug report.

@Cidan Cidan moved this from To triage to Backlog in BetterBags Issue Tracker Feb 21, 2024
@SpareSimian
Copy link

The text is part of the item's tooltip and not part of the data in the current version of the addon. So the search function needs to pull the tooltip data and scan through it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
Status: Backlog
Development

No branches or pull requests

4 participants