From c93b7088c2a6bffd0cec24909797bde4cb6095b8 Mon Sep 17 00:00:00 2001 From: Chocobozzz Date: Tue, 19 Dec 2023 07:26:09 +0100 Subject: [PATCH] Fix downloading video files from object storage With title that contains non ISO 8859 characters --- server/core/lib/object-storage/pre-signed-urls.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/core/lib/object-storage/pre-signed-urls.ts b/server/core/lib/object-storage/pre-signed-urls.ts index bbb19a57cc5..8da98e2464e 100644 --- a/server/core/lib/object-storage/pre-signed-urls.ts +++ b/server/core/lib/object-storage/pre-signed-urls.ts @@ -18,7 +18,7 @@ export async function generateWebVideoPresignedUrl (options: { const command = new GetObjectCommand({ Bucket: CONFIG.OBJECT_STORAGE.WEB_VIDEOS.BUCKET_NAME, Key: buildKey(key, CONFIG.OBJECT_STORAGE.WEB_VIDEOS), - ResponseContentDisposition: `attachment; filename=${downloadFilename}` + ResponseContentDisposition: `attachment; filename=${encodeURI(downloadFilename)}` }) const url = await getSignedUrl(await getClient(), command, { expiresIn: 3600 * 24 }) @@ -41,7 +41,7 @@ export async function generateHLSFilePresignedUrl (options: { const command = new GetObjectCommand({ Bucket: CONFIG.OBJECT_STORAGE.STREAMING_PLAYLISTS.BUCKET_NAME, Key: buildKey(key, CONFIG.OBJECT_STORAGE.STREAMING_PLAYLISTS), - ResponseContentDisposition: `attachment; filename=${downloadFilename}` + ResponseContentDisposition: `attachment; filename=${encodeURI(downloadFilename)}` }) const url = await getSignedUrl(await getClient(), command, { expiresIn: 3600 * 24 })