Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes directions are not normalized #170

Open
hamogu opened this issue Nov 3, 2017 · 1 comment
Open

Sometimes directions are not normalized #170

hamogu opened this issue Nov 3, 2017 · 1 comment

Comments

@hamogu
Copy link
Member

hamogu commented Nov 3, 2017

While the code does not really required normalized direction vectors, it would be good for consistency to enforce that. The way forward is probably to add this to optical element testing to identify optical elements that distort the normalization and then see if that's OK (and just re-normalize after passing through that element) or indicative of a bug.

@hamogu
Copy link
Member Author

hamogu commented May 25, 2018

With the "propagate" function that I'm considering now, code will actually require that (or I would normalize at every point where it's required).
I think a better strategy would be to identify where it's not normalized and fix those and then add a test for test_all_optical_elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant