wip: debugging windows CI #207
Merged
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously I hard-coded the path to libtorch. This commit replaces the hard-code path using `pip show` to get the updated location.
TomMelt
force-pushed
the
test-simple-change
branch
from
a8f1ea6 to
c87fd97
Compare
jatkinson1000
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Thanks @TomMelt
The exact semantics are still a mystery, but I can satisfy myself in what this is doing and how it resolves the issue and the CI is passing. Obviously not tested locally, but LGTM.
|
This fixes an issue detected in #206 |
jwallwork23
approved these changes
Dec 18, 2024
|
I merged this branch into the one for #206 and can confirm it gets it working! |
This was referenced Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously I hard-coded the path to
libtorchi.e.,-DCMAKE_PREFIX_PATH="C:\hostedtoolcache\windows\Python\3.12.7\x64\Lib\site-packages".This commit replaces the hard-code path using
pip showto get the updated location and store it in a variable%torch_path%for later use i.e.,-DCMAKE_PREFIX_PATH=%torch_path%