-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linting for shell and GitHub Actions #206
Conversation
Previously I hard-coded the path to libtorch. This commit replaces the hard-code path using `pip show` to get the updated location.
#207 has been merged into the branch here so should be merged first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They seem active projects.
I note zizmor is in beta, so perhaps we want to pin the version similar to fortitude, to avoid unexpected complaints.
We also need the docs updating to detail these, and I note that shellcheck is not pip installable. Seems installable via all sensible package managers. I wouldn't know where to start with Windows packaga managers, but don't see this as an issue as our docs state "follow the instructions in the linter docs".
Thanks @jatkinson1000. Addressed in 2834064. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jwallwork23 All LGTM now!
More linting!
Adds linting for shell and GitHub Actions workflows:
Also fixes an oversight in the CMake linting setup.