Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advection in Fourier space broken #23

Open
vpuri3 opened this issue Jun 27, 2022 · 2 comments
Open

Advection in Fourier space broken #23

vpuri3 opened this issue Jun 27, 2022 · 2 comments

Comments

@vpuri3
Copy link
Member

vpuri3 commented Jun 27, 2022

https://github.com/vpuri3/PDEInterfaces.jl/blob/940aee9cf3decda3583c03c6fbcfeff649daaaae/src/Spaces/TrigonometricPolynomials/Fourier.jl#L333-L367

product is being formed in modal space. not real space. i think the way to do this is to write a FunctionOperator:

function advect(duh, uh, p, t)
    # get vh from p
    v <- F \ Xh  * vh
    u <- F \ Xh * Dh * uh
    duh <- F \ (v * u)
end
@vpuri3
Copy link
Member Author

vpuri3 commented Jun 27, 2022

would have to fix SciML/SciMLOperators.jl#56

@vpuri3
Copy link
Member Author

vpuri3 commented Jun 27, 2022

or just figure out how to do adjoints, dealasing correctly by learning fourier methods properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant