Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CakePHP 4 support #190

Open
Erwane opened this issue Feb 3, 2020 · 6 comments
Open

CakePHP 4 support #190

Erwane opened this issue Feb 3, 2020 · 6 comments

Comments

@Erwane
Copy link
Collaborator

Erwane commented Feb 3, 2020

I'm using this plugin since years now and i want to create a PR to support Cakephp4 with bootstrap4.

From which branch should i start please ?

@Holt59
Copy link
Collaborator

Holt59 commented Feb 3, 2020

You should start with the https://github.com/Holt59/cakephp3-bootstrap-helpers/tree/v4.0.3 branch.

@Erwane
Copy link
Collaborator Author

Erwane commented Feb 10, 2020

Thanks, i'm on it.

I'm looking the project name and versions and do you plan to rename it "cakephp-bootstrap-helpers" and think about a notation branchs for versions ?
cake3-bootstrap3, cake3-bootstrap4, cake4-bootstrap4 ?

@Erwane
Copy link
Collaborator Author

Erwane commented Mar 5, 2020

@Holt59
Copy link
Collaborator

Holt59 commented Mar 6, 2020

@Erwane Thanks for all the work!

I have to check what implies a renaming of the Github project, I think Github can provide a redirection to the new project from the old URL but I'd have to check.

For the version, it's a bit more complicated unfortunately... For the branch names, there are currently no issues, but for composer to work properly there are some constraints on tagging (e.g., if you want 3.2.* or something like that).

@Erwane
Copy link
Collaborator Author

Erwane commented Mar 6, 2020

Proposal :

  • 3.3.x.y : cake 3, Bs 3
  • 3.4.x.y : cake 3, Bs 4
  • 4.4.x.y : cake 4, Bs 4

We only have "patch" (x) and "release" (y) numbers for new helpers or fixes.

In composer :
composer require holt59/cakephp-bootstrap:"^3.4.0" for cake 3 with bootstrap 4

@Holt59
Copy link
Collaborator

Holt59 commented Mar 6, 2020

@Erwane Yes, I think it's the best idea. And it does not break current versions which is a good thing. I will try to move everything to the new scheme this week-end and update the README(s) accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants