Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap 4 custom radio/checkbox #187

Open
1 of 3 tasks
Erwane opened this issue Oct 16, 2019 · 3 comments
Open
1 of 3 tasks

Bootstrap 4 custom radio/checkbox #187

Erwane opened this issue Oct 16, 2019 · 3 comments

Comments

@Erwane
Copy link
Collaborator

Erwane commented Oct 16, 2019

  • bug

  • enhancement

  • question

  • Plugin Version/Branch: dev-4.0.1-alpha.

Bootstrap 4 include nice custom radio and checkbox inputs
This could be integrated as template and option of radio and checkbox types ?

https://getbootstrap.com/docs/4.3/components/forms/#custom-forms

Thanks

@Holt59
Copy link
Collaborator

Holt59 commented Oct 16, 2019

Thanks for the idea, I was pretty sure to have started implementing these some times ago but I can't find anything in the history...

  • The custom file browser is already implemented but might be out-of-date.
  • The custom select should be easy to implement as it is simply a different template (replacing form-control with custom-select).
  • The standard range is not implemented, so I'll have to see how to implement this first, and then having custom range should not be complicated.
  • The three other ones (checkbox / radio / switch) are pretty similar, and likely a bit more complicated as I need to customize the label classes for these, I'll have to see what can be done. One possibility is to use different instance of the standard widgets, with different templates.

@Erwane
Copy link
Collaborator Author

Erwane commented Oct 16, 2019

"non related" question but why not create a real v4 branch ? bootstrap 4 is no more in alpha now

@Holt59
Copy link
Collaborator

Holt59 commented Oct 16, 2019

@Erwane The -alpha is (was) about the helpers being in version alpha, not Bootstrap :) According to packagist, there is between 15 and 20 daily installs of these, so I think we can move them out of alpha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants