Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap 4 - Breadcumb #103

Closed
Emilvooo opened this issue Feb 3, 2017 · 3 comments
Closed

Bootstrap 4 - Breadcumb #103

Emilvooo opened this issue Feb 3, 2017 · 3 comments

Comments

@Emilvooo
Copy link

Emilvooo commented Feb 3, 2017

Hi!

When using the HTML helper it does the breadcrumbs wrong. Instead of ol its does ul. Also the classes in the li are wrong.

This is what it should be in Bootstrap 4: http://getbootstrap.com/components/#breadcrumbs

And i do indeed use the bootstrap 4 variant of the plugin. `

breadcrumb
breadcrumb-code

@Holt59
Copy link
Collaborator

Holt59 commented Feb 3, 2017

Hi,

The v4 branch is currently outdated, I was waiting for a more stable release of bootstrap 4 to refactor it.

Note that the getBreadcrumbs method is deprecated for a more generic BreadcrumbsHelper in CakePHP.

I will try to update the v4 branch once I've finished cleaning the documentation of the current branch.

@Emilvooo
Copy link
Author

Emilvooo commented Feb 3, 2017

Alright, thanks!

@Holt59 Holt59 added the bug label Feb 9, 2017
@Holt59
Copy link
Collaborator

Holt59 commented Apr 30, 2018

I am closing this in favor of a more generic issue #153, feel free to comment there if you have any feedback!

@Holt59 Holt59 closed this as completed Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants