Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BufferedWriter is never closed #6

Open
Johni0702 opened this issue Jan 11, 2022 · 0 comments
Open

BufferedWriter is never closed #6

Johni0702 opened this issue Jan 11, 2022 · 0 comments

Comments

@Johni0702
Copy link

The BufferedWriter created at

at/src/main/java/org/cadixdev/at/io/AbstractAccessTransformFormat.java

Line 55 in c2b92fc

write(new BufferedWriter(writer), set);

is never actually flushed/closed. So the given writer usually only ever gets incomplete data (unless it is already a BufferedWriter itself).
Juuxel added a commit to architectury/at that referenced this issue Dec 15, 2023
@Juuxel
Fix created buffered writer not flushing
d4ac59b 
Fixes CadixDev#6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Johni0702