Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The executing line highlighting should animate the scroll to line #2

Open
dmwyatt opened this issue Jan 30, 2020 · 2 comments
Open

Comments

@dmwyatt
Copy link

dmwyatt commented Jan 30, 2020

It's jarring and confusing, particularly when the next line is many lines away from the current line.

For example, in the animation in the README, when it scrolls to the insertion_sort function implementation, it's not immediately clear what happened.

A possibly better implementation would have some sort of animation showing the scroll to that point and the movement of the highlight to that point.

@kdrag0n
Copy link
Collaborator

kdrag0n commented Jan 30, 2020

I'm not so sure it's a good idea because it might be a bit distracting and/or out-of-place. For example, most terminals don't have smooth scrolling in order to keep all the text aligned and some editors behave the same way.

I'll look into it though, thanks for the suggestion.

@dmwyatt
Copy link
Author

dmwyatt commented Jan 30, 2020

Yes, I agree that most terminals do not do this. However, it seems like that might not be so relevant to a tool that is at least partly designed for learning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants