You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
mitk::Pointer(s) are typedef'd itk::SmartPointer(s)
[HERE IN PHIEstimator] there is a maskImageTmp->Delete(); which should probably be mitkImageTmp = NULL.
I think the "issue" is that if you call Delete() the smart pointer will be destroyed regardless of the number of references it holds, while the = NULL just decreases the reference counter by one and deletes it only if it reaches 0. It doesn't look like it matters here, but we should stick to the correct ways.
The text was updated successfully, but these errors were encountered:
Let me preface this by saying that I'm not exactly sure about this, but here it goes.
Turns out the correct way to delete itk SmartPointer(s) is
smartPointer = NULL;
[ITK REFERNCE - look at "Coding Style">"DO NOT"]mitk::Pointer(s) are typedef'd itk::SmartPointer(s)
[HERE IN PHIEstimator] there is a
maskImageTmp->Delete();
which should probably bemitkImageTmp = NULL
.I think the "issue" is that if you call Delete() the smart pointer will be destroyed regardless of the number of references it holds, while the
= NULL
just decreases the reference counter by one and deletes it only if it reaches 0. It doesn't look like it matters here, but we should stick to the correct ways.The text was updated successfully, but these errors were encountered: