Improve devcontainer to replicate vscode behavior #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Devcontainer configuration might be saved on .devcontainer folder or .devcontainer.json. This commit add the missing support for .devcontainer.json file.
vscode mounts the entire project (where .git is located) on /workspace. This commit changes the script behavior to find the .git folder, mount this bind and use the current workspace inside the docker just like vscode.
The output of a docker build command is not an image hash and this were causing error on docker run command. This commit parses the build command output to extract only the hash and use later to run the docker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
First of all, thank you for this script.
I found some issues using the script (image hash, workspace location and
.devcontainer.jsonfile) so I updated the script to suppport these.Would you like to review/merge it?
Best regards,
Ian Maciel