Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Prometheus endpoint #67

Open
MaartenMol opened this issue Dec 19, 2018 · 4 comments
Open

[Feature Request] Prometheus endpoint #67

MaartenMol opened this issue Dec 19, 2018 · 4 comments
Labels
approved Enhancement or request that was approved to be worked on enhancement New feature or request help-wanted Extra attention is needed

Comments

@MaartenMol
Copy link

Add an /metrics endpoint so that Prometheus can scrape from it. This way we can choose what TSDB to use.
@MaartenMol MaartenMol added the awaiting-triage Request awaiting triage label Dec 19, 2018
@dirtycajunrice dirtycajunrice added not-a-varken-issue This doesn't seem right wont-fix This will not be worked on and removed awaiting-triage Request awaiting triage labels Dec 19, 2018
@dirtycajunrice
Copy link
Member

adding an endpoint would require hosting a flask app and defining a port. This was not the design choice for us and was designed to pull information only, not be pulled from. I suggest you looking into the already existing integration built for this between prometheus_read and influxdb. https://docs.influxdata.com/influxdb/v1.7/supported_protocols/prometheus/

@Boerderij Boerderij locked and limited conversation to collaborators Mar 19, 2019
@Boerderij Boerderij unlocked this conversation Sep 19, 2019
@dirtycajunrice
Copy link
Member

Further knowledge has shown that the prometheus python module is fully capable of doing this. Re-opening and leaving for when either i have time or someone would like to attempt :D

@dirtycajunrice dirtycajunrice added approved Enhancement or request that was approved to be worked on enhancement New feature or request and removed not-a-varken-issue This doesn't seem right wont-fix This will not be worked on labels Sep 19, 2019
@dirtycajunrice dirtycajunrice added the help-wanted Extra attention is needed label Sep 19, 2019
@dirtycajunrice
Copy link
Member

https://github.com/Boerderij/Varken/tree/prometheus-exporter WIP

@PrivatePuffin
Copy link

Slight addition:
Someone informed me InfluxDB 2.0 also supports pulling Prometheus datasources, which means implementing this also de-facto solves #159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved Enhancement or request that was approved to be worked on enhancement New feature or request help-wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PrivatePuffin @MaartenMol @dirtycajunrice