Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it compatible with Sonarr/Radarr V4 #252

Open
Speedmod88 opened this issue Apr 19, 2023 · 9 comments
Open

make it compatible with Sonarr/Radarr V4 #252

Speedmod88 opened this issue Apr 19, 2023 · 9 comments
Labels
awaiting-triage Request awaiting triage

Comments

@Speedmod88
Copy link

well as the title said, we are now with Sonarr/Radarr V4 so the queuelist doesnt work anymore

if anyone can update the code to work with the newer version

Thanks a lot

@Speedmod88 Speedmod88 added the awaiting-triage Request awaiting triage label Apr 19, 2023
@MDHMatt
Copy link

MDHMatt commented May 12, 2023

can you share your logs so can see what is up?

@Speedmod88
Copy link
Author

Speedmod88 commented May 15, 2023

sure so here what I got for sonarr

2023-05-14 10:04:29 : DEBUG : init : Running job Job(interval=300, unit=seconds, do=thread, args=(<bound method SonarrAPI.get_queue of >,), kwargs={})
2023-05-14 10:04:29 : DEBUG : init : Running job Job(interval=300, unit=seconds, do=thread, args=(<bound method SonarrAPI.get_calendar of >,), kwargs={'query': 'Missing'})
2023-05-14 10:04:29 : DEBUG : connectionpool : Resetting dropped connection: ********1.253
2023-05-14 10:04:29 : DEBUG : connectionpool : Resetting dropped connection: ********1.253
2023-05-14 10:04:29 : DEBUG : init : Running job Job(interval=300, unit=seconds, do=thread, args=(<bound method SonarrAPI.get_calendar of >,), kwargs={'query': 'Future'})
2023-05-14 10:04:29 : DEBUG : connectionpool : Resetting dropped connection: ********1.253
2023-05-14 10:04:29 : DEBUG : connectionpool : http://********1.253:8989 "GET /api/v3/queue?pageSize=250&includeSeries=True&includeEpisode=True&includeUnknownSeriesItems=False HTTP/1.1" 200 None
2023-05-14 10:04:29 : DEBUG : connectionpool : Resetting dropped connection: ********1.253
2023-05-14 10:09:30 : DEBUG : connectionpool : http://********1.253:8989 "GET /api/v3/calendar/?pageSize=1000&start=2023-05-14&end=2023-05-15&includeSeries=True HTTP/1.1" 200 None
2023-05-14 10:09:30 : DEBUG : connectionpool : http://********1.253:8989 "GET /api/v3/calendar/?pageSize=1000&start=2023-05-07&end=2023-05-14&includeSeries=True HTTP/1.1" 200 None
2023-05-14 10:09:30 : ERROR : sonarr : TypeError has occurred : SonarrEpisode.new() got an unexpected keyword argument 'runtime' while creating SonarrEpisode structure for show. Data attempted is: {'seriesId': 4286, 'tvdbId': 9696130, 'episodeFileId': 0, 'seasonNumber': 1, 'episodeNumber': 9, 'title': 'Deerfest (1)', 'airDate': '2023-05-10', 'airDateUtc': '2023-05-10T07:00:00Z', 'runtime': 29, 'overview': 'Cass and Dusty deal with the fallout from the magic show. Trina comes clean about Jacob. An approaching storm threatens Deerfield.', 'hasFile': False, 'monitored': True, 'unverifiedSceneNumbering': False, 'series': {'title': 'The Big Door Prize', 'sortTitle': 'big door prize', 'status': 'continuing', 'ended': False, 'overview': 'A small town is forever changed when a mysterious machine appears, promising to reveal everyone’s true potential. Soon residents start changing jobs, rethinking relationships, and questioning long-held beliefs—all in pursuit of a better future.', 'network': 'Apple TV+', 'airTime': '03:00', 'images': [{'coverType': 'banner', 'remoteUrl': 'https://artworks.thetvdb.com/banners/v4/series/403752/banners/643c52b80476d.jpg'}, {'coverType': 'poster', 'remoteUrl': 'https://artworks.thetvdb.com/banners/v4/series/403752/posters/640f476147864.jpg'}, {'coverType': 'fanart', 'remoteUrl': 'https://artworks.thetvdb.com/banners/v4/series/403752/backgrounds/6423d5b2eecf1.jpg'}], 'originalLanguage': {'id': 1, 'name': 'English'}, 'seasons': [{'seasonNumber': 1, 'monitored': True}], 'year': 2023, 'path': '/data/Plex/TV-FR/The Big Door Prize {tvdb-403752}', 'qualityProfileId': 1, 'seasonFolder': True, 'monitored': True, 'useSceneNumbering': False, 'runtime': 32, 'tvdbId': 403752, 'tvRageId': 0, 'tvMazeId': 55638, 'firstAired': '2023-03-29T00:00:00Z', 'seriesType': 'standard', 'cleanTitle': 'thebigdoorprize', 'imdbId': 'tt14761860', 'titleSlug': 'the-big-door-prize', 'certification': 'TV-MA', 'genres': ['Comedy'], 'tags': [], 'added': '2023-04-22T17:11:50Z', 'ratings': {'votes': 0, 'value': 0}, 'languageProfileId': 1, 'id': 4286}, 'grabbed': False, 'id': 143443}
2023-05-14 10:09:30 : ERROR : sonarr : TypeError has occurred : SonarrEpisode.new() got an unexpected keyword argument 'runtime' while creating SonarrEpisode structure for show. Data attempted is: {'seriesId': 4288, 'tvdbId': 9613659, 'episodeFileId': 0, 'seasonNumber': 1, 'episodeNumber': 11, 'title': 'Unfamiliar Partnerships', 'airDate': '2023-05-10', 'airDateUtc': '2023-05-11T02:00:00Z', 'runtime': 41, 'overview': 'When an ex-Omega Sector operative asks the team to help stop the sale of weaponized uranium, Harry finds himself struggling to reconcile his loyalty between his current team and his former comrade, who continually demonstrates some questionable, yet effective, tactics.', 'hasFile': False, 'monitored': True, 'absoluteEpisodeNumber': 11, 'unverifiedSceneNumbering': False, 'series': {'title': 'True Lies', 'sortTitle': 'true lies', 'status': 'continuing', 'ended': False, 'overview': 'Harry is a first-class international spy for U.S. intelligence agency Omega Sector, and his wife, Helen, a language professor bored with her daily routine, makes the shocking discovery that her seemingly ordinary husband is leading an extraordinary double life. With the secret out, Omega recruits Helen, who impresses everyone with her formidable skills, and she joins Harry and his team of top-notch operatives, embarking on covert missions around the globe and an exhilarating life of danger and adventure … all while keeping their adventures a secret from their three teenage children. The renewed bond between them adds much-needed sizzle to the Taskers’ emotionally distant marriage and upends the top-secret world of Omega Sector. But, as Harry says, if you’re going to save the world, you might as well do it for the ones you love.', 'network': 'CBS', 'airTime': '22:00', 'images': [{'coverType': 'banner', 'remoteUrl': 'https://artworks.thetvdb.com/banners/v4/series/420096/banners/63e586117c1c3.jpg'}, {'coverType': 'poster', 'remoteUrl': 'https://artworks.thetvdb.com/banners/v4/series/420096/posters/63f0df599c4cc.jpg'}, {'coverType': 'fanart', 'remoteUrl': 'https://artworks.thetvdb.com/banners/v4/series/420096/backgrounds/63e584bd26ee6.jpg'}], 'originalLanguage': {'id': 1, 'name': 'English'}, 'seasons': [{'seasonNumber': 1, 'monitored': True}], 'year': 2023, 'path': '/data/Plex/TV-FR/True Lies {tvdb-420096}', 'qualityProfileId': 1, 'seasonFolder': True, 'monitored': True, 'useSceneNumbering': False, 'runtime': 42, 'tvdbId': 420096, 'tvRageId': 0, 'tvMazeId': 57470, 'firstAired': '2023-03-01T00:00:00Z', 'seriesType': 'standard', 'cleanTitle': 'truelies', 'imdbId': 'tt7380366', 'titleSlug': 'true-lies', 'certification': 'TV-14', 'genres': ['Action'], 'tags': [], 'added': '2023-04-22T17:11:50Z', 'ratings': {'votes': 0, 'value': 0}, 'languageProfileId': 1, 'id': 4288}, 'grabbed': False, 'id': 143467}
2023-05-14 10:09:30 : WARNING : sonarr : No data to send to influx for sonarr-calendar instance, discarding.

@Healzangels
Copy link

Greetings!
Also seeing the same things within my logs for Sonarr
ERROR : sonarr : TypeError has occurred : SonarrQueue.__new__() got an unexpected keyword argument 'seasonNumber' while creating Queue structure. Data attempted is:

As well for Radarr
: ERROR : radarr : TypeError has occurred : RadarrMovie.__new__() got an unexpected keyword argument 'rootFolderPath' while creating RadarrMovie structure

Saw from #251 looks like changes may have been merged to develop 3 days ago. Double checked and my container is update to date w/latest develops release but still seeing the errors above.

Thanks for any assistance can provide/gladly provide any additional logs etc. -Cheers

@Speedmod88
Copy link
Author

Speedmod88 commented Jul 7, 2023

hey, thanks for the update in the develop branch -> boerderij/varken:develop

but same as Healzangels,

for Radarr:

2023-07-06 22:26:14 : DEBUG : connectionpool : http://********1.253:7878 "GET /api/v3/movie HTTP/1.1" 200 None
2023-07-06 22:26:15 : ERROR : radarr : TypeError has occurred : RadarrMovie.new() got an unexpected keyword argument 'rootFolderPath' while creating RadarrMovie structure

but seem to be fixed for sonarr on my side

thanks a lot :)

@Navino16
Copy link

Same issue here, I hope it will be fixed

@modem7
Copy link

modem7 commented Jan 1, 2024

Here are my logs from the start of 01/01/24 if required:

Both Sonarr and Radarr is affected.

Varken-2024-01-01T23-03-11.log

Sonarr and Radarr have now made it to v4 and v5 respectively on master branches.

@evanrich
Copy link

evanrich commented Mar 19, 2024

Hella late, but you guys can fix this yourself. I discovered the RadarrMovie.new() got an unexpected keyword argument 'rootFolderPath' while creating RadarrMovie structure error after importing the repo into my own git server in order to patch the base image to the latest python/alpine versions and bump all the requirements because trivvy was complaining. To fix this, edit the following:

class RadarrMovie(NamedTuple):

and add the following 2 lines (in alphabetical order to keep things easy to follow):

rootFolderPath: str = None
statistics: dict = None

I'll update this if i find more, I had to use the radarr api here: https://radarr.video/docs/api/#/Movie/get_api_v3_movie in order to figure out the output from radarr. I'm rolling my own image for now, but I'll fork the develop branch and add the fix in there once I see if there are any more (I first did the root folder one, then got a new error for statistics, there could be more)

fWIW, I'm using radarr v5, so not sure if my changes will work in older versions.

Here is the start of my fork: evanrich/Varken@develop...evanrich-update-to-new-radarr-sonnar

There are a bunch of things missing, I got passed radarr and now have sonarr errors. I'll do a PR -> develop branch once I get mine all sorted out

I've opened a PR that fixes these errors #260

@gokou340
Copy link

Hella late, but you guys can fix this yourself. I discovered the RadarrMovie.new() got an unexpected keyword argument 'rootFolderPath' while creating RadarrMovie structure error after importing the repo into my own git server in order to patch the base image to the latest python/alpine versions and bump all the requirements because trivvy was complaining. To fix this, edit the following:

class RadarrMovie(NamedTuple):

and add the following 2 lines (in alphabetical order to keep things easy to follow):

rootFolderPath: str = None
statistics: dict = None

I'll update this if i find more, I had to use the radarr api here: https://radarr.video/docs/api/#/Movie/get_api_v3_movie in order to figure out the output from radarr. I'm rolling my own image for now, but I'll fork the develop branch and add the fix in there once I see if there are any more (I first did the root folder one, then got a new error for statistics, there could be more)

fWIW, I'm using radarr v5, so not sure if my changes will work in older versions.

Here is the start of my fork: evanrich/[email protected]

There are a bunch of things missing, I got passed radarr and now have sonarr errors. I'll do a PR -> develop branch once I get mine all sorted out

I've opened a PR that fixes these errors #260

Thank you for fixing this. I built a docker image based on the #260. I confirmed that it works with the latest version(as of this writing) of Sonarr and Radarr, as well as support for Overseerr. I built and pushed my first docker image with these changes, so if anyone wants to pull it to use, it is: gokou360/varken:dev-v4api

Thanks again @evanrich!

@evanrich
Copy link

Hella late, but you guys can fix this yourself. I discovered the RadarrMovie.new() got an unexpected keyword argument 'rootFolderPath' while creating RadarrMovie structure error after importing the repo into my own git server in order to patch the base image to the latest python/alpine versions and bump all the requirements because trivvy was complaining. To fix this, edit the following:

class RadarrMovie(NamedTuple):

and add the following 2 lines (in alphabetical order to keep things easy to follow):

rootFolderPath: str = None
statistics: dict = None

I'll update this if i find more, I had to use the radarr api here: https://radarr.video/docs/api/#/Movie/get_api_v3_movie in order to figure out the output from radarr. I'm rolling my own image for now, but I'll fork the develop branch and add the fix in there once I see if there are any more (I first did the root folder one, then got a new error for statistics, there could be more)
fWIW, I'm using radarr v5, so not sure if my changes will work in older versions.
Here is the start of my fork: evanrich/[email protected]
There are a bunch of things missing, I got passed radarr and now have sonarr errors. I'll do a PR -> develop branch once I get mine all sorted out
I've opened a PR that fixes these errors #260

Thank you for fixing this. I built a docker image based on the #260. I confirmed that it works with the latest version(as of this writing) of Sonarr and Radarr, as well as support for Overseerr. I built and pushed my first docker image with these changes, so if anyone wants to pull it to use, it is: gokou360/varken:dev-v4api

Thanks again @evanrich!

No problem @gokou340 ! I also am now rolling my own image internally (hosting on a harbor instance in my cluster) since it looks like this will probably never get updated here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-triage Request awaiting triage
Projects
None yet
Development

No branches or pull requests

7 participants