From f71025113c2eca0a031d9ec4806bd59f44623831 Mon Sep 17 00:00:00 2001 From: Pramod S Kumbhar Date: Wed, 18 Oct 2023 21:19:37 +0200 Subject: [PATCH] address review --- .github/workflows/nmodl-ci.yml | 2 +- azure-pipelines.yml | 2 +- test/unit/visitor/defuse_analyze.cpp | 5 ++--- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/workflows/nmodl-ci.yml b/.github/workflows/nmodl-ci.yml index 70ab03d48e..40932e8c5f 100644 --- a/.github/workflows/nmodl-ci.yml +++ b/.github/workflows/nmodl-ci.yml @@ -17,7 +17,7 @@ on: env: CTEST_PARALLEL_LEVEL: 1 PYTHON_VERSION: 3.8 - DESIRED_CMAKE_VERSION: 3.15 + DESIRED_CMAKE_VERSION: 3.15.0 jobs: ci: diff --git a/azure-pipelines.yml b/azure-pipelines.yml index 34b0c2b2a6..02f96583f4 100644 --- a/azure-pipelines.yml +++ b/azure-pipelines.yml @@ -136,7 +136,7 @@ stages: fi ./bin/nrnivmodl-core $(Build.Repository.LocalPath)/test/integration/mod env: - CMAKE_PKG: 'cmake-3.17.0-Linux-x86_64' + CMAKE_PKG: 'cmake-3.15.0-Linux-x86_64' SHELL: 'bash' displayName: 'Build Neuron and Run Integration Tests' - job: 'osx11' diff --git a/test/unit/visitor/defuse_analyze.cpp b/test/unit/visitor/defuse_analyze.cpp index 6c20ca9bf6..4c9a0b64dd 100644 --- a/test/unit/visitor/defuse_analyze.cpp +++ b/test/unit/visitor/defuse_analyze.cpp @@ -448,7 +448,7 @@ SCENARIO("Perform DefUse analysis on NMODL constructs") { GIVEN("Simple check of assigned variables") { const std::string nmodl_text = R"( NEURON { - GLOBAL x + SUFFIX foo } ASSIGNED { @@ -456,8 +456,7 @@ SCENARIO("Perform DefUse analysis on NMODL constructs") { } DERIVATIVE states { - x = 1 - y = x + y = 1 y = y + 2 } )";