Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Htlcs expired long time ago and payment still pending #485

Open
roeierez opened this issue Jul 21, 2024 · 3 comments
Open

Htlcs expired long time ago and payment still pending #485

roeierez opened this issue Jul 21, 2024 · 3 comments
Assignees
Labels
solution::rescan state::fixed This issue was addressed in a PR and will be closed once it is merged state::upstream These are issues that are related to upstream projects and should be tackled there. upstream::cln

Comments

@roeierez
Copy link
Collaborator

roeierez commented Jul 21, 2024

flowchart LR
  bsr[BSR#83] <--> glp[GLP#485]
  click glp href "https://github.com/Blockstream/greenlight/issues/485"
  click bsr href "https://github.com/breez/breez-sdk-relai/issues/83"
Loading

Relai issue: https://github.com/breez/breez-sdk-relai/issues/83

I see two inflight htlcs that have been expired a long time ago and the channel is still opened:

htlcs: [ListpeerchannelsChannelsHtlcs { direction: Some(Out), id: Some(116), amount_msat: Some(Amount { msat: 222231188 }), expiry: Some(851933), payment_hash: Some([251, 162, 173, 3, 4, 70, 47, 41, 66, 211, 192, 116, 89, 241, 51, 47, 224, 60, 227, 198, 199, 102, 123, 180, 240, 178, 210, 205, 159, 187, 201, 213]), local_trimmed: None, status: None, state: Some(SentRemoveRevocation) }, ListpeerchannelsChannelsHtlcs { direction: Some(Out), id: Some(115), amount_msat: Some(Amount { msat: 97768235 }), expiry: Some(851933), payment_hash: Some([251, 162, 173, 3, 4, 70, 47, 41, 66, 211, 192, 116, 89, 241, 51, 47, 224, 60, 227, 198, 199, 102, 123, 180, 240, 178, 210, 205, 159, 187, 201, 213]), local_trimmed: None, status: None, state: Some(SentRemoveRevocation) }, ListpeerchannelsChannelsHtlcs { direction: Some(Out), id: Some(118), amount_msat: Some(Amount { msat: 135644467 }), expiry: Some(851933), payment_hash: Some([251, 162, 173, 3, 4, 70, 47, 41, 66, 211, 192, 116, 89, 241, 51, 47, 224, 60, 227, 198, 199, 102, 123, 180, 240, 178, 210, 205, 159, 187, 201, 213]), local_trimmed: None, status: None, state: Some(SentRemoveRevocation) }], close_to_addr: Some("bc1plfvjvrc5uhhruc3nfkva5h0g2me67u85l540kp7e33y0val0kqeqs0f9nl") }] }

@roeierez
Copy link
Collaborator Author

Here is another case for this issue: https://github.com/breez/breez-sdk-relai/issues/40#issuecomment-2242591325

@cdecker cdecker added state::upstream These are issues that are related to upstream projects and should be tackled there. state::fixed This issue was addressed in a PR and will be closed once it is merged upstream::cln solution::rescan labels Jul 22, 2024
@cdecker
Copy link
Collaborator

cdecker commented Jul 22, 2024

As far as I can see we somehow missed the sweep of output 3, which is the second stage HTLC transaction, thus we continued trying to push the second stage out. This is a bug in CLN we are currently hunting down, but we can restart the node with --rescan=-height where height is below the close, and have it trace through the entire close again.

I did that, and the next time the user comes online (with its signer) it'll go through the close. If the user doesn't close the app too soon, we should automatically pick everything up.

@cdecker cdecker self-assigned this Jul 22, 2024
@roeierez
Copy link
Collaborator Author

@cdecker see this: https://github.com/breez/breez-sdk-relai/issues/83#issuecomment-2256143016
Are you abel to check if the rescan has finished?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solution::rescan state::fixed This issue was addressed in a PR and will be closed once it is merged state::upstream These are issues that are related to upstream projects and should be tackled there. upstream::cln
Projects
None yet
Development

No branches or pull requests

2 participants