Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autologging breaks logs in M+ keys #1330

Open
ljosberinn opened this issue Jan 13, 2023 · 1 comment
Open

Autologging breaks logs in M+ keys #1330

ljosberinn opened this issue Jan 13, 2023 · 1 comment
Labels

Comments

@ljosberinn
Copy link

Describe the problem

BigWigs autologging breaks logs in M+ keys as it stops logging on ENCOUNTER_END which gets fired multiple times in a dungeon. Consider adopting the same approach MRT uses:

  • in Raid zones, keep the current behaviour
  • in Mythic 0 zones, start logging and stop once you zone out. this may catch some Mythic 0 trash but WCL separates these based on CHALLENGE_MODE_START/_END anyways

What steps will reproduce the problem?

  1. Enable autologging in settings
  2. Start a key
  3. Upload the log after the key or use live logging
  4. Observe how either:
  • the log records up until the end of the first boss of the dungeon and nothing after
  • the log records up until the end of the first boss of the dungeon and only bosses onwards
  • the log records exclusively bosses

What version of BigWigs are you using? (Stating 'latest' is not useful)

Latest, but this is a long outstanding issue for at least 6 months.

Do you have an error log of what happened?

No error thrown.

Any additional information? (example: WoW language if not English)

Suggestion: do not stop logging if CHALLENGE_MODE_START was observed, until CHALLENGE_MODE_END is seen OR another CHALLENGE_MODE_START (due to abandoning a key)

@ljosberinn
Copy link
Author

we're getting a report of this being an issue every other day, any plans on this? it's nearing its first birthday :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant