From 0a73ca1599935fdfd4cac8185ab00ca745a155ac Mon Sep 17 00:00:00 2001 From: smudge Date: Wed, 13 Nov 2024 12:45:38 -0500 Subject: [PATCH] Linter --- .rubocop_todo.yml | 20 ++++++------------- .../admin/screenshots_controller.rb | 1 + spec/requests/admin/screenshots_spec.rb | 1 + 3 files changed, 8 insertions(+), 14 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 08010175..585fdc8e 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 99999999999` -# on 2023-03-28 16:02:29 UTC using RuboCop version 1.46.0. +# on 2024-11-13 17:45:18 UTC using RuboCop version 1.46.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -11,11 +11,12 @@ Betterment/NonStandardActions: Exclude: - 'config/routes.rb' -# Offense count: 13 +# Offense count: 14 Betterment/UnscopedFind: Exclude: - 'app/controllers/admin/bulk_assignments_controller.rb' - 'app/controllers/admin/decisions_controller.rb' + - 'app/controllers/admin/screenshots_controller.rb' - 'app/controllers/admin/split_configs_controller.rb' - 'app/controllers/admin/split_details_controller.rb' - 'app/controllers/admin/splits_controller.rb' @@ -44,12 +45,11 @@ Layout/ArgumentAlignment: - 'spec/models/deterministic_assignment_creation_spec.rb' - 'spec/models/visitor_supersession_spec.rb' -# Offense count: 2 +# Offense count: 1 # This cop supports safe autocorrection (--autocorrect). Layout/EmptyLines: Exclude: - 'config/initializers/devise.rb' - - 'config/routes.rb' # Offense count: 1 # This cop supports safe autocorrection (--autocorrect). @@ -76,7 +76,7 @@ Layout/LineLength: - 'config/initializers/devise.rb' - 'config/initializers/simple_form.rb' -# Offense count: 11 +# Offense count: 10 # This cop supports safe autocorrection (--autocorrect). Lint/RedundantCopDisableDirective: Exclude: @@ -88,7 +88,6 @@ Lint/RedundantCopDisableDirective: - 'app/models/arbitrary_assignment_creation.rb' - 'app/models/concerns/delegate_attribute.rb' - 'app/models/deterministic_assignment_creation.rb' - - 'app/models/split_upsert.rb' - 'app/models/visitor_supersession.rb' - 'lib/test_track/attachment_settings.rb' @@ -156,12 +155,11 @@ Rails/EnumHash: Exclude: - 'app/models/split.rb' -# Offense count: 6 +# Offense count: 5 # Configuration parameters: EnforcedStyle. # SupportedStyles: slashes, arguments Rails/FilePath: Exclude: - - 'config/environments/development.rb' - 'lib/tasks/seed_app.rake' - 'spec/rails_helper.rb' - 'spec/requests/api/v1/split_details_spec.rb' @@ -210,12 +208,6 @@ Style/ColonMethodCall: Exclude: - 'config/initializers/airbrake.rb' -# Offense count: 1 -# This cop supports safe autocorrection (--autocorrect). -Style/ExpandPathArguments: - Exclude: - - 'config.ru' - # Offense count: 2 # This cop supports unsafe autocorrection (--autocorrect-all). Style/GlobalStdStream: diff --git a/app/controllers/admin/screenshots_controller.rb b/app/controllers/admin/screenshots_controller.rb index 506f03da..b3ebe964 100644 --- a/app/controllers/admin/screenshots_controller.rb +++ b/app/controllers/admin/screenshots_controller.rb @@ -1,4 +1,5 @@ # frozen_string_literal: true + class Admin::ScreenshotsController < ApplicationController def show split = Split.find(params[:split_id]) diff --git a/spec/requests/admin/screenshots_spec.rb b/spec/requests/admin/screenshots_spec.rb index cd063bab..468d077a 100644 --- a/spec/requests/admin/screenshots_spec.rb +++ b/spec/requests/admin/screenshots_spec.rb @@ -1,4 +1,5 @@ # frozen_string_literal: true + require 'rails_helper' RSpec.describe Admin::ScreenshotsController do