You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I hope this is an OK place to put this, but perhaps an additional test might be needed for bb.join with no method:
// This is a stack trace from an Ember app where an async component action is being run, and the route is navigated away to another page during that time. I'm pretty sure there is no problem with the app code.Uncaught(inpromise) TypeError: Cannotreadproperty'apply'ofundefinedatBackburner._join(backburner.js:995)atBackburner.join(backburner.js:760)atFunction.join(index.js:168)atProxy.routeAction(route-action.js:53)atinvokeAction(invoke-action.js:13)atrunSearch(search.js:98)atSelectBox.search(index.js:327)atindex.js:249
// backburner.js_join(target,method,args){if(this.currentInstance===null){returnthis._run(target,method,args);}if(target===undefined&&args===undefined){returnmethod();}else{returnmethod.apply(target,args);// `method` is undefined}}
I did a quick skim of our test coverage and noticed a few holes where we need some coverage:
bb.defer
is untested (yes, it is deprecated, but it should still have a test given that it is public API)bb.on
andbb.off
are not tested (passing no eventName, or passing no callback)end called without begin
error thrown inbb.end()
is not testedbb.later()
e.g. with no arguments. This should be an error IMHO, but currently just returns earlybb.ensureInstance()
is public API that has no testsbb.join(function() { })
(no target or args) when within a run-loop (e.g. when we are actually joining an existing loop) has no testsbb.join(function() { }, someArg)
(no target with args) when within a run-loop (e.g. when we are actually joining an existing loop) has no tests} else { end = middle; }
inbinary-search
has no testsQueue.prototype.flush
with a custombefore
/after
has no testsThe text was updated successfully, but these errors were encountered: