Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

136 mixturedesign mapping #139

Closed
wants to merge 3 commits into from
Closed

136 mixturedesign mapping #139

wants to merge 3 commits into from

Conversation

alFrie
Copy link
Collaborator

@alFrie alFrie commented Mar 21, 2023

In order to make the mapping to placeholders work, the key-names in the extraction script need to fit the placeholders.

Since the raw data we have doesn't fit to the MixDesign Ontology (which is made for different types of cement, CemI, CemII), and we don't have any suitable raw data, I created a new extraction-script that will make our raw data work with the MixDesign Ontology: mixdesign_metadata_extraction.py

The old script (mixture_metadata_extraction.py) won't get touched so that it won't be lost and can be easily adjusted if one day we have a MixOntology that suits that raw data.

I explained the difference between those two scripts in a readme.

@alFrie alFrie linked an issue Mar 21, 2023 that may be closed by this pull request
3 tasks
@alFrie alFrie self-assigned this Mar 21, 2023
@alFrie
Copy link
Collaborator Author

alFrie commented Mar 21, 2023

The mixDesign-extraction produces a yaml-file that works with the new uploaded mixture-mapping-script.
The following three placeholder recieve no value:
['CEMIIDensity_Value', 'CEMIIQtyInMix_Value', 'MixtureID_Value']

It is clear that everything related to Cem-II won't recieve values, since our raw data has only one typ of cement and it's information is saved in Cem-I.
But the MixtureID needs to be solved. Since the mixture-mapping is basically just an altered version of the emodule-mapping it currently still includes a function to generate a specimenID which gets appended to every instance-name.
Now shouldn't this ID be identical to the one used in emodule? We should discuss this in the next biweekly meeting, @joergfunger .

The checks need to be adjusted to this version of the mapping script.

@alFrie alFrie mentioned this pull request Mar 21, 2023
3 tasks
@alFrie
Copy link
Collaborator Author

alFrie commented Apr 25, 2023

Update: No new mapping script for mixture is planned, instead we will use the same one as for emodule (#118 (comment)).

@alFrie
Copy link
Collaborator Author

alFrie commented May 9, 2023

I am closing this pull request and will delete the branch, because it is better to work on the MixDesign Extraction on the same branch as for emodule. A seperate mapping script is not needed.

@alFrie alFrie closed this May 9, 2023
@alFrie alFrie deleted the 136-mixturedesign-mapping branch May 9, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MixtureDesign Mapping
1 participant