Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider creating ClientAssertionCredential and implementing WorkloadIdentityCredential in terms of it #4905

Closed
ahsonkhan opened this issue Aug 22, 2023 · 4 comments · Fixed by #5802
Assignees
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Milestone

Comments

@ahsonkhan
Copy link
Member

ahsonkhan commented Aug 22, 2023

Other languages like .NET and GoLang have this credential. We can start with this being private implementation detail of WIC and turn it to be public once there is a customer need for it in C++.

https://github.com/Azure/azure-sdk-for-net/blob/a932f53e2fc200cee443614a0bf991b02b518055/sdk/identity/Azure.Identity/src/Credentials/ClientAssertionCredential.cs#L18
https://github.com/Azure/azure-sdk-for-go/blob/e7968b534c61da1e38a683e21ac690deb14833c7/sdk/azidentity/client_assertion_credential.go#L26

WIC composing CAC:
https://github.com/Azure/azure-sdk-for-go/blob/e7968b534c61da1e38a683e21ac690deb14833c7/sdk/azidentity/workload_identity.go#L28

cc @chlowell

@joshfree joshfree moved this from Untriaged to Backlog in Azure Identity SDK Improvements Aug 22, 2023
@RickWinter RickWinter added feature-request This issue requires a new behavior in the product in order be resolved. Client This issue points to a problem in the data-plane of the library. labels Aug 24, 2023
@ahsonkhan ahsonkhan added this to the 2024-06 milestone May 20, 2024
@ahsonkhan ahsonkhan moved this from Backlog to In Progress in Azure Identity SDK Improvements May 20, 2024
@ahsonkhan ahsonkhan self-assigned this May 20, 2024
@ahsonkhan
Copy link
Member Author

This is needed for #4968

@joshfree joshfree modified the milestones: 2024-06, 2024-07, 2024-08 Jun 24, 2024
@sershe-ms
Copy link

Hmm, since #4968 is closed, is it possible to expose this class for compatibility with the C# SDK?

@ahsonkhan
Copy link
Member Author

We are looking for scenarios where customers would need a ClientAssertionCredential, exposed publicly in C++.

Can you please share details on how you'd use it and what your requirements are for using this credential in C++? What's motivating the need for C# compatibility?

@sershe-ms
Copy link

We are adding Azure support as a plugin to librdkafka Kafka client library. Some of the users of the library are using federated credentials, not just pure MSI, to have more fine-grained access control (as far as I understand)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
4 participants