Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP trigger logic app with array type as input prompts save without changes #6206

Closed
nicholasdemos opened this issue Dec 3, 2024 · 3 comments · May be fixed by #6224
Closed

HTTP trigger logic app with array type as input prompts save without changes #6206

nicholasdemos opened this issue Dec 3, 2024 · 3 comments · May be fixed by #6224
Assignees
@ccastrotrejo

Comments

@nicholasdemos
Copy link

nicholasdemos commented Dec 3, 2024 •
edited by github-actions bot
Loading

Describe the Bug with repro steps

  1. Create a new consumption logic app with a HTTP trigger
  2. In the Request Body JSON Schema, define an input property of type "array"
  3. Save and close the Logic App
  4. Click Edit to open the logic app in designer view
  5. Observe the Save button is enabled, prompting for save when no edits have been made
  6. Closing the designer without any editing also then prompts dialog "Your unsaved edits will be discarded."

What type of Logic App Is this happening in?

Consumption (Portal)

Which operating system are you using?

Windows

Are you using new designer or old designer

New Designer

Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg

Yes

Workflow JSON

{
    "definition": {
        "$schema": "https://schema.management.azure.com/providers/Microsoft.Logic/schemas/2016-06-01/workflowdefinition.json#",
        "contentVersion": "1.0.0.0",
        "triggers": {
            "manual": {
                "type": "Request",
                "kind": "Http",
                "inputs": {
                    "schema": {
                        "properties": {
                            "p1": {
                                "type": "array"
                            }
                        },
                        "required": [
                            "p1"
                        ],
                        "type": "object"
                    }
                }
            }
        },
        "actions": {
            "Response": {
                "type": "Response",
                "kind": "Http",
                "inputs": {
                    "statusCode": 200,
                    "body": "@triggerBody()"
                },
                "runAfter": {}
            }
        },
        "outputs": {},
        "parameters": {
            "$connections": {
                "type": "Object",
                "defaultValue": {}
            }
        }
    },
    "parameters": {
        "$connections": {
            "value": {}
        }
    }
}

Screenshots or Videos

No response

Browser

Edge

Additional context

No response
@ccastrotrejo ccastrotrejo self-assigned this Dec 4, 2024
@ccastrotrejo
Copy link
Contributor

Hi @nicholasdemos thanks for raising this issue. I was able to repro it. I will come up with a fix for it

@ccastrotrejo ccastrotrejo mentioned this issue Dec 5, 2024
Open
@ccastrotrejo
Copy link
Contributor

Hi @nicholasdemos, I have made the necessary changes for the fix. This will be deployed to production by mid-January next year. However, it seems that the workflow functionality is not affected. The issue only causes the designer to appear as if it has been modified and enables the command bar buttons. Other than that, everything should work as expected. Please let us know if you encounter any issues.

@nicholasdemos
Copy link
Author

Hi @ccastrotrejo , that's great news, thank you for the update.

@github-actions github-actions bot closed this as completed Dec 6, 2024
@ccastrotrejo ccastrotrejo mentioned this issue Dec 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ccastrotrejo ccastrotrejo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(designer): Add ignore dirty prop to updateNodeSettings action Azure/LogicAppsUX
2 participants
@nicholasdemos @ccastrotrejo