Incorrect renewal order totals on the checkout when subscription was manually created

[mattallan]

Describe the bug

Manually creating a subscription via the WooCommerce > Subscriptions > Add Subscription creates a subscription with an incorrect prices_include_tax value that does not match the stores tax settings.

When this subscription renews and customers go to pay for the pending order via the checkout, the checkout totals don't properly include the tax:

Edit Order screen:

❌ Checkout page:

When stores have their tax settings set to "I will enter prices inclusive of tax", we should be creating subscriptions with the correct value set for prices_include_tax that match the stores settings.

A few things to note from my testing:

• This only impacts manual renewals. If I manually create a subscription and add stripe payment met and process a renewal, the transaction in stripe is for the correct amount.
• If your store is using the block checkout, refreshing the checkout page will fix the incorrect totals problem. Refreshing the shortcode checkout does not fix it.

To Reproduce

1. Go to WooCommerce > Settings > Tax (wp-admin/admin.php?page=wc-settings&tab=tax) and set **
   Prices entered with tax** to "Yes, I will enter prices inclusive of tax"
2. Make sure your store has a valid tax rate (i.e. global 10%)
3. Go to WooCommerce > Subscriptions > Add Subscription
4. Create an active subscription with a $10 subscription product and make sure you recalculate totals to apply the tax calculations.
5. Use the "Process Renewal" subscription action to create a pending renewal order.
6. Go to My Account > Orders and attempt to pay for the pending order and notice the price on the checkout does not match the price of the subscription (it will have the tax amount taken off)

Product impact

• Does this issue affect WooCommerce Subscriptions? yes/no/tbc, add issue ref
• Does this issue affect WooCommerce Payments? yes/no/tbc, add issue ref

Additional context

[mattallan]

While working on a fix in Subscriptions I realised this fix should go in WooCommerce Core as it impacts both orders and subscriptions.
I've created an issue over there: woocommerce/woocommerce#51426

Closing this.

[mattallan]

PR opened in WooCommerce core: woocommerce/woocommerce#51428