Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap function callbacks #104

Open
robertgoss opened this issue Jul 16, 2020 · 1 comment
Open

Wrap function callbacks #104

robertgoss opened this issue Jul 16, 2020 · 1 comment
Assignees

Comments

@robertgoss
Copy link
Collaborator

Currently function callbacks are passed directly over the interface as arguments.

This leads to 2 issues:

  1. We cannot journal calls into these callbacks from within the implementation - which we would like to do in the future
  2. This does not follow the hourglass isolation pattern as an exception thown in the callback might not be safely able to percolate in the implementations code.

To get around this we should wrap the function call backs we are passed from the binding in the implementation.

@alexanderoster
Copy link

Hi @robertgoss, I just found an issue (#129) that might be directly related to your project. It would be great to hear your opinion about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants