Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate API calls from reading logic for testing #183

Open
dbrakenhoff opened this issue Jan 10, 2024 · 0 comments
Open

Separate API calls from reading logic for testing #183

dbrakenhoff opened this issue Jan 10, 2024 · 0 comments

Comments

@dbrakenhoff
Copy link
Collaborator

Our tests often fail because APIs are unavailable because of maintenance, changes in its call signature or just tired from dealing with our requests. This is annoying, so we would ideally change our testing to split the reading of data from the testing of the API call.

Basic idea:

  • separate the API calls from the reading logic (perhaps also useful for allowing multi-threaded downloading as was implemented for Lizard?).
  • test all reading logic on pre-downloaded files (e.g. BRO XML, KNMI precipitation txt, etc.)
  • minimize the API tests to only test the response from the server and whether the returned data can be parsed
  • mark the API tests to allow-fail so we do get a warning when these tests fail but it isnt necessarily a block on development
  • ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant