Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Docker Healthcheck broken since newest update #615

Open
saschabrockel opened this issue Mar 26, 2024 · 5 comments
Open

[BUG] Docker Healthcheck broken since newest update #615

saschabrockel opened this issue Mar 26, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@saschabrockel
Copy link

Describe the bug
I'm running this health command curl --fail http://localhost:8080/api/health || exit 1 for the health check of the container. Since the newest update, it's not working anymore. I can do the exact same command in the container itself without problems.

I'm on master#5977f7c.

The container health logs say the following
OCI runtime exec failed: exec failed: unable to start container process: exec: "/bin/sh": stat /bin/sh: no such file or directory: unknown

@saschabrockel saschabrockel added the bug Something isn't working label Mar 26, 2024
@AnalogJ AnalogJ closed this as completed Mar 26, 2024
@saschabrockel
Copy link
Author

Sorry but what is the fix? I cannot see it.

I'm using it like this:
--health-cmd="curl --fail http://localhost:8080/api/health || exit 1" --health-interval=1m --health-timeout=10s --health-retries=3

It is done as recommended. I don't think it has anything to do with this.

@AnalogJ
Copy link
Owner

AnalogJ commented Mar 26, 2024

apologies, I referenced the wrong Issue. Here's the correct one - #601

Basically if you're using Docker-compose, you need to specify the shell array syntax.

I'm actually not sure if theres a way to do that when using the docker cli...

Let me re-open this issue.

@AnalogJ AnalogJ reopened this Mar 26, 2024
@AnalogJ
Copy link
Owner

AnalogJ commented Mar 26, 2024

@AnalogJ
Copy link
Owner

AnalogJ commented Mar 27, 2024

I considered baking the healthcheck into the docker build, however that will cause issues for users that change their default port.

Might still be worth it

@TimGels
Copy link

TimGels commented Apr 11, 2024

Did that baking in already happen? I am unable to use Scrutiny now as I have put it on a different port. Changing the port back to 8080 seems to work, otherwise the web container says it's unhealthy. But is not really a good solution as it is a very common port which I do not want to dedicate to Scrutiny. I don't think that breaking the possibility to change ports is the way forward.

Okay no, my issue seems unrelated. But I still think creating issues for users who change the default port is not a good balanced decision compared to the advantages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants