Skip to content
This repository has been archived by the owner on Jan 7, 2021. It is now read-only.

New Feature suggestion - Include code coverage, and alert if quality gate fail on Pull request #192

Closed
datasmurfen opened this issue Sep 6, 2018 · 8 comments

Comments

@datasmurfen
Copy link

datasmurfen commented Sep 6, 2018

New Feature suggestion - Include code coverage, and alert if quality gate fail on pull request.

This is something I miss - today we use: https://github.com/kogitant/sonar-slack-notifier-plugin , but would be better to have this in one place.

@datasmurfen datasmurfen changed the title New Feature - Include code coverage, and alert if quality gate fail on Pull request New Feature suggestion - Include code coverage, and alert if quality gate fail on Pull request Sep 6, 2018
@t-8ch
Copy link
Contributor

t-8ch commented Sep 6, 2018

Hi @datasmurfen,
Can you elaborate about "Include Code coverage"?
The problem with the quality gate is that is executed asynchronously and has not yet finished when sonar-stash is running. (This is also tracked in #95)

@t-8ch
Copy link
Contributor

t-8ch commented Sep 6, 2018

Also the quality gate is not run on preview runs (See #95)

@datasmurfen
Copy link
Author

datasmurfen commented Sep 6, 2018

Right, could it be possible to get the latest quality gate analysis from the "full" run(not the preview run)? Not sure if that would help, but it's one way to do it, I guess?

@t-8ch
Copy link
Contributor

t-8ch commented Sep 6, 2018

Well, it could be done, but it would be really confusing. I am strongly -1 on it.

@datasmurfen
Copy link
Author

Yea I agree, it would be very confusing.

@t-8ch
Copy link
Contributor

t-8ch commented Sep 6, 2018

Could you elaborate on the coverage you want to see?
There is the coverage evolution plugin.
It has a few caveats that are documented its README

@datasmurfen
Copy link
Author

I think it would been great to see if your pull request brakes/fix the current quality gate with an comment on what you break.

Must Have

  • Coverage on New Code is less then X %
    And alert if that is less then quality gate with an comment in the PR.

Could have:

  • Duplicated Lines on New Code is less
  • Maintainability Rating on New Code
  • Reliability Rating on New Code
  • Security Rating
    Security Rating on New Code

@t-8ch
Copy link
Contributor

t-8ch commented Sep 6, 2018

Ok, so it's also tied to the quality gate.
As there is no quality gate available there is not much we can do.
This will probably happen at all, because SonarSource is promoting their own (closed, paid) branch and pull request solution.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants