Foot error messages #86
Conversation
…n quote blocks of the call, rather than directly calling the functions to create feet. Removed testing code.
neonWhiteout
force-pushed
the
foot_error_messages
branch
from
25cc9f9 to
9c491fc
Compare
if length(block.args) < 2 # case for create_foot(:())
return error("Cannot create foot with no arguments.")This would also trigger in the case where the expression has 1 argument, so something like :((A,)) would fail here |
…error, since it's trying to call a match_foot_format on :C, where the function is only defined on expressions.) removed testing code
neonWhiteout
force-pushed
the
foot_error_messages
branch
from
d6ed553 to
cc6fc13
Compare
|
You closed this without merging, should I change something here? @Xiaoyan-Li |
Sorry, no, I just closed it accidentally. Reopen just now |
|
Ah boy give me a few min. |
|
K throw this one in the trash for now. |
|
Passes tests on my end and shouldn't have any affect on the notebooks. |
|
Nevermind it failed the notebook examples, need to figure out why... |
|
@Saityi I don't know why this is failing the notebooks, seems like they fail to install IJulia and Conda? Any ideas? |
|
Fails notebook tests, but I think there's something screwed up with them |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #86 +/- ##
==========================================
+ Coverage 49.93% 50.03% +0.09%
==========================================
Files 9 9
Lines 1524 1525 +1
==========================================
+ Hits 761 763 +2
+ Misses 763 762 -1 ☔ View full report in Codecov by Sentry. |
Foot and feet correctly throw errors, now, instead of needing an eval. Motivated by #80