Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that oracles re-sync after priceFeeds update #9885

Closed
LuqiPan opened this issue Aug 13, 2024 · 1 comment
Closed

Verify that oracles re-sync after priceFeeds update #9885

LuqiPan opened this issue Aug 13, 2024 · 1 comment
Assignees

Comments

@LuqiPan
Copy link
Contributor

LuqiPan commented Aug 13, 2024

What is the Problem Being Solved?

The SimplyStaking oracle software tracks the roundId required by our priceFeeds when submitting price updates. When we replace the priceFeeds, (#9483, #9584), the new priceFeeds will start with a roundId of 0. There appears to be code in the oracles that checks the roundId in vstorage.

Description of the Design

Run a test on mainfork (#9866), Once the priceFeeds are setup, accept new invitations and verify that the oracles switch to the new feeds, and use the correct roundId. If they don't do so already, fix the oracle code so this will work.

Security Considerations

immaterial.

Scaling Considerations

N/A.

@Chris-Hibbert
Copy link
Contributor

duplicate of #9886

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants