Write a coreEval to add a new Auction #8918
Assignees
Labels
Comments
14 tasks
This was referenced Mar 27, 2024
Merged
mergify bot
added a commit
that referenced
this issue
Apr 29, 2024
refs: #8740 closes: #8918 refs: #8400 ## Description Add a new Auction instance in A3P, so #8757 can make use of it. Also provides upgrade proposals which can be be applied to MainNet and other chains. ### Security Considerations N/A ### Scaling Considerations This is largely in service of #8400, which reports that priceFeed vats are accumulating garbage. This PR gives a new auction which can rely on new priceFeeds. The existing auction is not upgradeable and its pricefeeds can't be updated. ### Documentation Considerations No user-visible changes to behavior. ### Testing Considerations Tested in A3P ### Upgrade Considerations Auctions are not upgradeable, so we have to replace them and update their clients.
mergify bot
added a commit
that referenced
this issue
May 6, 2024
closes: #8049 closes: #8740 closes: #8868 closes: #8918 closes: #8981 closes: #8079 refs: #8400 closes: #8735 closes: #7873 closes: #8726 closes: #7954 closes: #8757 closes: #8728 closes: #8789 ## Description Upgrade **VaultFactory** in A3P, relying on the new PriceFeeds, and auctions. The actual upgrade waits for the priceFeeds to start supplying before doing the upgrade, so there won't be any gap in priceUpdates. When the upgrade is finished, we also update the auctioneerKit and Auction instance in the bootstrap environment. This PR demonstrates that VaultFactory can be upgraded even though governance is not persistent (#8123). ### Security Considerations N/A ### Scaling Considerations This is largely in service of #8400, which reports that priceFeed vats are accumulating garbage. This PR switches to new priceFeeds, which won't have that problem, though cleaning up the existing vats is a task for the future. ### Documentation Considerations No changes to user-visible behavior. ### Testing Considerations A3P tests that verify that vaultFactory has been upgraded, that a new Auctioneer is running and is receiving prices. Verify that when prices drop, assets are sold via the auction, the bidder gets the proceeds, and the vaults are liquidated or reconstituted appropriately. ### Upgrade Considerations Upgrade all the vats!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the Problem Being Solved?
In Upgrade-15, we plan to add a new Auction, and upgrade vaults to rely on it. In order to test this, we need a core-eval in a3p-integration.
See #8740 for the overall plan for upgrading price feeds, of which this is a part.
Description of the Design
The new auction should subscribe to the recently updated priceFeeds as the older ones will be discontinued. The existing Auction should be de-scheduled, but not until vaults upgrade and use the new Auction.
Security Considerations
None.
Scaling Considerations
It's all in service of resolving some sustainability challenges caused by the old price feeds
Test Plan
Verify in a3p-integration that everything is happy afterwards.
Upgrade Considerations
Yes.
The text was updated successfully, but these errors were encountered: