walletFactory - migrate chain upgrade test to agoric-3-proposals

[dckc]

What is the Problem Being Solved?

code review in #8311 resulted in not only back-porting the walletFactory but also making some changes to it; for example:

• using instancePrivateArgs rather than rebuilding the private args
• reducing the scope/impact of the fakeStorage.getBody()

Meanwhile, there have been changes on master:

• proposal builder stuff moved to the builders package to address cycles in our package dependencies
• fix(walletFactory): move upgrading check before baggage is populated #8322

Description of the Design

Originally: It's not clear how to address all these goals:

• we want the docker upgrade-tests to mirror mainnet and hence use the exact bundle from the backport
• we want local-chain users to benefit from fix(walletFactory): move upgrading check before baggage is populated #8322 which fixed walletFactory fails to install bridge handler on first incarnation #8321
• we don't want to re-introduce cycles in our package dependencies

We came up with a design that addresses 2 of the 3:

Tasks

Preview Give feedback

1. feat: 49:smart-wallet-nft proposal agoric-3-proposals#12
   +0
   

Security Considerations

instancePrivateArgs is a pointy instrument. The choice of whether/how to use it is worth some consideration.

Scaling Considerations

Test Plan

Upgrade Considerations

[dckc]

Security Considerations

instancePrivateArgs is a pointy instrument. The choice of whether/how to use it is worth some consideration.

• how to grant limited authority to save contract upgrade materials? #8378

[dckc]

We have this working in agoric-3-proposals:

• feat: 49:smart-wallet-nft proposal agoric-3-proposals#12

I suppose I shouldn't close this until...

• Separate chain upgrade tests from SDK #8443

[dckc]

oops; accidentally closed it anyway

[dckc]

#8443 isn't critical path to the current consumer of this