Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Bank doesn't implement reward collectors when running agoric start #7435

Open
ivanlei opened this issue Apr 17, 2023 · 2 comments
Open
Labels
bug Something isn't working Inter-protocol Overarching Inter Protocol vaults_triage DO NOT USE

Comments

@ivanlei
Copy link
Contributor

ivanlei commented Apr 17, 2023

Describe the bug

Errors from startEconCommittee when running agoric start

2023-04-17T16:26:26.435Z SwingSet: vat: v1: coreProposal: startEconCharter
2023-04-17T16:26:26.460Z SwingSet: ls: v15: Logging sent error stack (Error#1)
2023-04-17T16:26:26.460Z SwingSet: ls: v15: Error#1: Bank doesn't implement reward collectors
2023-04-17T16:26:26.460Z SwingSet: ls: v15: Error: Bank doesn't implement reward collectors
 at apply ()
 at Error (/bundled-source/.../node_modules/ses/src/error/tame-error-constructor.js:54)
 at getRewardDistributorDepositFacet (.../vats/src/vat-bank.js:289)
 at apply ()
 at apply ()
 at dispatchToHandler (/bundled-source/.../node_modules/@endo/eventual-send/src/handled-promise.js:163)
 at win (/bundled-source/.../node_modules/@endo/eventual-send/src/handled-promise.js:511)
 at ()

2023-04-17T16:26:26.460Z SwingSet: ls: v15: Error#1 ERROR_NOTE: Sent as error:liveSlots:v15#70001
2023-04-17T16:26:26.492Z SwingSet: vat: v1: startWalletFactory needs wallet and provision bridgeManagers (not sim chain)
2023-04-17T16:26:26.505Z SwingSet: vat: v1: Cannot create fee collector deposit facet (RemoteError(error:liveSlots:v15#70001)#1)
2023-04-17T16:26:26.506Z SwingSet: vat: v1: RemoteError(error:liveSlots:v15#70001)#1: Bank doesn't implement reward collectors
2023-04-17T16:26:26.506Z SwingSet: vat: v1: Error: Bank doesn't implement reward collectors
 at construct ()
 at Error (/bundled-source/.../node_modules/ses/src/error/tame-error-constructor.js:56)
 at makeError (/bundled-source/.../node_modules/ses/src/error/assert.js:243)
 at decodeErrorCommon (/bundled-source/.../node_modules/@endo/marshal/src/marshal.js:281)
 at decodeFromSmallcaps (/bundled-source/.../node_modules/@endo/marshal/src/encodeToSmallcaps.js:434)
 at fromCapData (/bundled-source/.../node_modules/@endo/marshal/src/marshal.js:356)
 at notifyOnePromise (/bundled-source/.../packages/swingset-liveslots/src/liveslots.js:1216)
 at notify (/bundled-source/.../packages/swingset-liveslots/src/liveslots.js:1240)
 at dispatchToUserspace (/bundled-source/.../packages/swingset-liveslots/src/liveslots.js:1503)
 at runWithoutMetering (/bundled-source/.../packages/swingset-xsnap-supervisor/lib/supervisor-subprocess-xsnap.js:61)
 at ()

To Reproduce

Steps to reproduce the behavior:

  1. Sync agoric-sdk to HEAD of master, yarn && yarn build
  2. cd ~ && rm -rf demo
  3. cd demo && agoric install
  4. agoric start --reset --verbose

Expected behavior

No error messages

Platform Environment

  • what OS are you using?
    13.3.1 (22E261)
  • what version of Node.js?
➜  agoric-sdk git:(master) node --version
v16.20.0
  • is there anything special/unusual about your platform?
  • what version of the Agoric-SDK are you using? (run git describe --tags --always)
➜  agoric-sdk git:(master) git describe --tags --always
agoric-upgrade-8-1765-gc832a55a3
@ivanlei ivanlei added bug Something isn't working Inter-protocol Overarching Inter Protocol vaults_triage DO NOT USE labels Apr 17, 2023
@ivanlei ivanlei added this to the Vaults EVP milestone Apr 27, 2023
@ivanlei
Copy link
Contributor Author

ivanlei commented Apr 28, 2023

Verified still repro'ing as of this AM.

@ivanlei ivanlei removed this from the Vaults EVP milestone May 1, 2023
@dckc
Copy link
Member

dckc commented Jan 12, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Inter-protocol Overarching Inter Protocol vaults_triage DO NOT USE
Projects
None yet
Development

No branches or pull requests

2 participants