Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contract restart: v43-walletFactory #10493

Closed
mhofman opened this issue Nov 15, 2024 · 1 comment
Closed

Contract restart: v43-walletFactory #10493

mhofman opened this issue Nov 15, 2024 · 1 comment
Assignees
@Chris-Hibbert
Labels
enhancement New feature or request

Comments

@mhofman
Copy link
Member

mhofman commented Nov 15, 2024 •
edited
Loading

What is the Problem Being Solved?

The smart wallet seem to be experiencing a heap leak (#10706). Until we figure out where it's coming from, we need to restart v43-walletFactory periodically (each chain software upgrade)

Description of the Design

Include smart wallet restart in proposals for chain software upgrade

Security Considerations

None

Scaling Considerations

None

Test Plan

Existing acceptance tests in a3p

Upgrade Considerations

Verify heap snapshot size of v43 on mainfork upgrade.
@mhofman mhofman added the enhancement New feature or request label Nov 15, 2024
@mhofman mhofman changed the title Contract restart: v9-zoe Contract restart: v43-walletFactory Nov 15, 2024
This was referenced Dec 16, 2024
Open
Open
@mhofman
Copy link
Member Author

mhofman commented Dec 24, 2024

Smart wallet is getting upgraded in u18, and the cause of the leak was addressed in #10758 so closing this.

@mhofman mhofman closed this as completed Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chris-Hibbert Chris-Hibbert

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mhofman @Chris-Hibbert