Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark rules with webrtc option as invalid in the browser extension #113

Open
piquark6046 opened this issue Jan 6, 2024 · 1 comment
Open
Assignees

Comments

@piquark6046
Copy link
Member

piquark6046 commented Jan 6, 2024

Currently, AdGuard Browser Extension does not understand $stealth modifier with webrtc option.
If any filter with the $stealth=webrtc applied, the request or document will be allowed as a normal exception.

For example, if there is a filter as the following:

@@||moeni.net^$document,stealth=webrtc

the filter will be converted to:

@@||moeni.net^$document

Therefore, it causes AdguardTeam/AdguardFilters#169648 (comment).

Screenshots

Screenshot from 2024-01-06 11-09-28
Screenshot from 2024-01-06 11-12-43

@maximtop
Copy link
Contributor

maximtop commented Jan 9, 2024

It is impossible to disable webrtc by website. So we can just to not add such rules in the extension.

@maximtop maximtop changed the title Add webrtc option in stealth exception modifier Mark rules with webrtc option as invalid in the browser extension Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants