Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Equality of models is not two-way #99

Open
iskandarzulkarnaien opened this issue Oct 12, 2019 · 0 comments
Open

Equality of models is not two-way #99

iskandarzulkarnaien opened this issue Oct 12, 2019 · 0 comments
Labels
bug Something isn't working priority.Low Unlikely to do/Do when there's nothing left to work on type.Unexplained Unknown why something behaves this way

Comments

@iskandarzulkarnaien
Copy link

Starting from #97 , equality of the two models is not two way. i.e. A.equals(B) !== B.equals(A)

Unknown why behaviour is this way. Variables have been swapped such that result is true, so tests can pass.

Code fragment as such:

main/src/test/java/seedu/address/logic/commands/CommandTestUtil.java

Line 100 in ba8573c

assertEquals(expectedModel, actualModel);

@iskandarzulkarnaien iskandarzulkarnaien added bug Something isn't working type.Unexplained Unknown why something behaves this way priority.Low Unlikely to do/Do when there's nothing left to work on labels Oct 12, 2019
iskandarzulkarnaien added a commit that referenced this issue Oct 12, 2019
@iskandarzulkarnaien
Reverse order of equality check in CommandTestUtil (see issues #99)
b6c74b2
iskandarzulkarnaien added a commit that referenced this issue Oct 12, 2019
@iskandarzulkarnaien
Add doctor class (#97)
13c8945 
* Update AddCommandParser.java with doctor class support

* Fix typo in AddCommandParser

* Add Doctor class

* Update JsonAdaptedPerson

* Add DoctorCard class

* Update PersonListPanel

* Change ordering of person type checks to alphabetical order

* Change ordering of checks AddCommandParser to alphabetical

* Change ordering of checks in PersonListPanel to alphabetical

* Add DoctorListCard.fxml

* Fix typo in Type.java

* Add DoctorBuilder for tests

* Update TypicalPersons to reflect Doctor class

* Add DoctorTest

* Add toModelType test for Doctor class

* Update AddCommandTest for Doctor class

* Fix misc checkstyle issues

* Fix AddCommandTest doctor variable

* Fix Checkstyle Issues

* Change Person type references to Doctor in DoctorTest

* Reverse order of equality check in CommandTestUtil (see issues #99)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working priority.Low Unlikely to do/Do when there's nothing left to work on type.Unexplained Unknown why something behaves this way
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iskandarzulkarnaien