Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using the MSVC linker option /WX if the AVIF_ENABLE_WERROR cmake option is ON #2346

Open
wantehchang opened this issue Jul 31, 2024 · 1 comment

Comments

@wantehchang
Copy link
Collaborator

The MSVC linker has a /WX option to treat linker warnings as errors. It may make sense for libavif to use the /WX linker option if the AVIF_ENABLE_WERROR cmake option is ON.

My only concern is that AVIF_ENABLE_WERROR is about treating compiler warnings as errors, so we are using it for a different (but related) purpose.

@wantehchang
Copy link
Collaborator Author

I attached a prototype patch that adds the /WX linker option to avif.dll, avifenc.exe, and avifdec.exe: msvc-linker-WX-patch.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant