Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do train and test dataframes have to have the same column ordering ? #1258

Open
arun-dezerv opened this issue Jul 15, 2024 · 1 comment
Open

Comments

@arun-dezerv
Copy link

In sklearn, it is important to have the same column ordering between train and test sets. Is the same required in FinRL as well?

@krishdotn1
Copy link
Contributor

Hi @arun-dezerv
I do not think the same order of columns is required in test and train datasets. Finrl Extract data by column name like
data["col_name"] So you did not need to maintain column order.

p.s: But while creating an observation space in an environment you should maintain the order of values contains in observation space.
example,
Train Case:
obs = [cash, num_of_stock,close,indicators_value]
Test Case:
it should be same as Train.
obs = [cash, num_of_stock,close,indicators_value]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants