New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use regex in conversion driver file naming #123

Open

blimlim opened this issue Oct 2, 2024 · 0 comments

Labels

Collaborator

blimlim commented Oct 2, 2024

The conversion driver for ESM1.5 is currently extracts information from the input filenames, in order to produce an output file name:

um2nc-standalone/umpost/conversion_driver_esm1p5.py

Lines 145 to 148 in e2a39a7

    
           # TODO: Use regex to extract stem and unit from filename to improve  
        
           # clarity, and for better handling of unexpected filenames. 
        
           stem = fields_file_name[0:FF_UNIT_INDEX + 1] 
        
           unit = fields_file_name[FF_UNIT_INDEX]

This section of the code could be made clearer and more flexible by using regular expressions to extract this information.

blimlim added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment