Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin dind version pin for dynamic image building & binderhub charts #3588

Closed
3 tasks done
yuvipanda opened this issue Jan 8, 2024 · 2 comments
Closed
3 tasks done

Unpin dind version pin for dynamic image building & binderhub charts #3588

yuvipanda opened this issue Jan 8, 2024 · 2 comments
Labels
allocation:internal-eng

Comments

@yuvipanda
Copy link
Member

yuvipanda commented Jan 8, 2024 •
edited by consideRatio
Loading

When merging #3585, I saw that it failed for binderhub-service (https://github.com/2i2c-org/infrastructure/actions/runs/7451299461/job/20273916986). Looking deeper, it seems to be due to docker-library/docker#463.

I've temporarily pinned the dind version to the previous one (#3589), which works.

Action Items

  • Check if upstream (docker) has merged and deployed the change that fixes the issue we were facing
  • Test the change by removing the pin in our config
  • If the change works, remove the pin in our config (essentially reverting Fix crashing docker daemon in binderhub-staging #3589)
@github-project-automation github-project-automation bot moved this to Needs Shaping / Refinement in DEPRECATED Engineering and Product Backlog Jan 8, 2024
yuvipanda added a commit to yuvipanda/pilot-hubs that referenced this issue Jan 8, 2024
@yuvipanda
Fix crashing docker daemon in binderhub-staging
f76de91 
Ref 2i2c-org#3588
@yuvipanda yuvipanda mentioned this issue Jan 8, 2024
Merged
@yuvipanda
Copy link
Member Author

I also documented this debugging session in https://youtube.com/live/lWp5BItlde4?feature=share

yuvipanda added a commit to 2i2c-org/binderhub-service that referenced this issue Jan 16, 2024
@yuvipanda
Temporarily pin dind image tag
2a92fd5 
See 2i2c-org/infrastructure#3588
for tracking issue
@yuvipanda yuvipanda mentioned this issue Jan 16, 2024
Merged
yuvipanda added a commit to 2i2c-org/binderhub-service that referenced this issue Jan 16, 2024
@yuvipanda
Temporarily pin dind image tag
49bff18 
See 2i2c-org/infrastructure#3588
for tracking issue
@damianavila damianavila moved this to In Progress ⚡ in Sprint Board Jan 18, 2024
@damianavila damianavila moved this to In Progress in BinderHub-JupyterHub Jan 18, 2024
@damianavila damianavila moved this from In Progress ⚡ to Waiting 🕛 in Sprint Board Jan 18, 2024
@yuvipanda yuvipanda changed the title binderhub dind pods broken due to upstream (docker) issue Unpin dind version pin for dynamic image building & binderhub charts Feb 2, 2024
@yuvipanda yuvipanda removed their assignment Feb 3, 2024
@yuvipanda yuvipanda mentioned this issue Feb 8, 2024
Merged
@ggarza31416 ggarza31416 mentioned this issue Jul 8, 2024
Open
@consideRatio
Copy link
Contributor

This is unpinned in binderhub-service and the binderhub chart is removed - resolved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
allocation:internal-eng
Projects
No open projects
BinderHub-JupyterHub
Status: In Progress
DEPRECATED Engineering and Product Backlog
Status: Needs Shaping / Refinement
Sprint Board
Status: Waiting 🕛
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yuvipanda @consideRatio