Skip to content
This repository has been archived by the owner on Jul 27, 2023. It is now read-only.

BooleanColumn is wrong #36

Open
i-panov opened this issue Dec 26, 2018 · 1 comment
Open

BooleanColumn is wrong #36

i-panov opened this issue Dec 26, 2018 · 1 comment

Comments

@i-panov
Copy link

i-panov commented Dec 26, 2018

I think that there is an error in this line. What do you mean by the $treatEmptyAsFalse parameter? The function empty will not pass any empty value. Not 0, not empty string, not false, not null etc... If it comes to that, I would rewrite this line like this: if (!is_null($value)) {. But now it definitely works wrong!

@tonydspaniard
Copy link
Member

Thanks @i-panov I'll have a look

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants