Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitmap uses fallback protocol unless on 512x512 8x8 #19

Open
cykadash opened this issue Mar 15, 2024 · 8 comments
Open

Bitmap uses fallback protocol unless on 512x512 8x8 #19

cykadash opened this issue Mar 15, 2024 · 8 comments
Labels
bug Something isn't working stabilizing Solved on latest, waiting for confirmation that the change works.

Comments

@cykadash
Copy link

It seems like the bitmap always uses the fallback protocol unless on 512x512 pixels and 8x8 units. I am on Linux if that makes a difference.

@1whatleytay
Copy link
Owner

Argh!! Yeah, linux is especially picky with custom Tauri protocols. This might also affect MIDI playback (since it uses a special protocol too). Going to investigate this in a VM this week.

@1whatleytay
Copy link
Owner

Out of curiosity, does smaller resolutions work? Like 32x32 1x1? For reference, 512x512 8x8 should be equivalent to 64x64 1x1, which is fairly small. Bitmap display units is more of a legacy feature, it was added to help people using MARS instructions (where units have a confusing but real meaning).

@cykadash
Copy link
Author

Sorry just saw this, 32x32 1x1 does not work either, going to see if wine does the trick

@1whatleytay
Copy link
Owner

Hey, I've done some experimenting on a Linux VM and I've identified the issue. It's also worth noting this is a regression from around v0.1.7 time I think? So version v0.1.5 shouldn't have this problem (and I think v0.1.6 is good too).

The issue has to do with CORS and sending headers on Linux, if you're curious. Pretty cursed.

@cykadash
Copy link
Author

Ohhh interesting, thank you

@cykadash
Copy link
Author

Funnily enough the main reason why this bug is annoying is while debugging, yet v0.1.7 adds a lot of debugging features that I would be using.

@1whatleytay
Copy link
Owner

Hey, I've pushed a fix to the v0.1.9 branch. Should land about ~20 mins after this comment. Can you download it here https://github.com/1whatleytay/saturn/releases/tag/app-v0.1.9 and tell me if it works?

@cykadash
Copy link
Author

Yes it works! Thank you so much

@1whatleytay 1whatleytay added bug Something isn't working stabilizing Solved on latest, waiting for confirmation that the change works. labels Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stabilizing Solved on latest, waiting for confirmation that the change works.
Projects
None yet
Development

No branches or pull requests

2 participants