Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listing supertypes; should we be exhaustive? #487

Open
ViktorHaag opened this issue Jan 30, 2020 · 2 comments
Open

Listing supertypes; should we be exhaustive? #487

ViktorHaag opened this issue Jan 30, 2020 · 2 comments
Labels
Documentation this issue requires a document update On Hold

Comments

@ViktorHaag
Copy link
Contributor

ViktorHaag commented Jan 30, 2020

It might be a good idea to list the path upwards of supertypes wherever we provide a supertype:

  • AggregateMeasure's supertype list would then be: Entity
  • AggregateMeasureCollection's supertype list would then be: Collection; Entity

This can helpfully help people not have to hope through a trail in the reference for finding supertypes, especially when there are two or more in the path up to the root Entity or Event.

We could also explicitly indicate that the property inheritance also works all the way up the inheritance chain... so the Person properties description should say something like (emphasis notes addition):

Person inherits all properties defined by its supertypes Agent and Entity, of which id and type are required.

@joshuamcghee
Copy link
Contributor

@ViktorHaag I've queued up this issue for review on 2/5/2020 call

@joshuamcghee
Copy link
Contributor

Per discussion on the call, this is a nice to have but will be put on hold for the time being.

@joshuamcghee joshuamcghee added the Documentation this issue requires a document update label Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation this issue requires a document update On Hold
Projects
None yet
Development

No branches or pull requests

2 participants